Edit NFTs [1/2]: Redo /settings/nfts to account for all project NFT states
#4051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
…rface into launch-nfts-from-nfts-page
johnnyd-eth
commented
Sep 4, 2023
| </span> | ||
| <Button type="primary" onClick={() => setEnableNftsModalOpen(true)}> | ||
| <span> | ||
| <Trans>Enable NFTs</Trans> |
There was a problem hiding this comment.
This button enables operator permissions (allow NFT contract reconfig FC)
johnnyd-eth
commented
Sep 4, 2023
| @@ -65,111 +65,109 @@ export const useReconfigureFundingCycle = ({ | |||
| const reconfigureV2V3FundingCycleWithNftsTx = | |||
| useReconfigureV2V3FundingCycleWithNftsTx() | |||
|
|
|||
| const { | |||
There was a problem hiding this comment.
The diff went whack here but the only thing that's changed is:
- Flesh out the
editingFundingCycleConfigobject insidereconfigureFundingCycle()rather than outside - Add optional
latestEditingData?: EditingFundingCycleConfigtoreconfigureFundingCycle() - Dependencies changed
johnnyd-eth
force-pushed
the
launch-nfts-from-nfts-page
branch
from
2e2e7bb to
09ce682
Compare
johnnyd-eth
force-pushed
the
launch-nfts-from-nfts-page
branch
from
09ce682 to
1de4d41
Compare
johnnyd-eth
force-pushed
the
launch-nfts-from-nfts-page
branch
from
1de4d41 to
0eae60f
Compare
johnnyd-eth
force-pushed
the
launch-nfts-from-nfts-page
branch
from
0eae60f to
7900a13
Compare
johnnyd-eth
changed the title
/settings/nfts to account for all project NFT states
johnnyd-eth
changed the title
/settings/nfts to account for all project NFT states/settings/nfts to account for all project NFT states
|
error when editing collection for this proj. it uses the latest NFT contracts so it may be a bug unrelated to this PR 
|
tomquirk
approved these changes
Sep 8, 2023
| @@ -43,8 +44,8 @@ export function EnableNftsModal({ | |||
| confirmLoading={loading} | |||
| > | |||
| <Trans> | |||
| To add NFTs to your cycle. You'll need to{' '} | |||
| <strong>grant NFT permissions</strong> before launching your new cycle. | |||
| To add NFTs to your next cycle, you'll need to{' '} | |||
| @@ -65,111 +65,109 @@ export const useReconfigureFundingCycle = ({ | |||
| const reconfigureV2V3FundingCycleWithNftsTx = | |||
| useReconfigureV2V3FundingCycleWithNftsTx() | |||
|
|
|||
| const { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry this one's quite fat, this solves all the NFT states exclusively within
settings/nfts:Project already has NFTs (no UI changes):
Project has no NFTs and operator permissions not set:
Kapture.2023-09-04.at.20.44.43.mp4
-> then, after automatic page reload once
setOperatorPermissioncompletes ->Project has no NFTs, operator permissions are set:
Kapture.2023-09-04.at.20.51.46.mp4