Skip to content

Commit

Permalink
Hide fee from settings payouts modals (#4073)
Browse files Browse the repository at this point in the history
  • Loading branch information
johnnyd-eth authored Sep 18, 2023
1 parent 07bdf8e commit b309c81
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ export function HeaderRows() {
onOk={handleAddRecipientModalOk}
onCancel={() => setAddRecipientModalOpen(false)}
hideProjectOwnerOption
hideFee
/>
</>
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ export function PayoutSplitRow({
onOk={handleEditModalOk}
onCancel={() => setEditModalOpen(false)}
hideProjectOwnerOption
hideFee
/>
</>
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export function TotalRows() {
<Cell>
<TooltipLabel
tip={t`The unallocated portion of your total will go to the wallet that owns the project by default.`}
label={<Trans>Remaining balance (Project Owner)</Trans>}
label={<Trans>Remaining (to project owner)</Trans>}
/>
</Cell>
<Cell>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ export const AddEditAllocationModal = ({
onOk,
onCancel,
hideProjectOwnerOption,
hideFee,
}: {
className?: string
allocationName: string
Expand All @@ -64,6 +65,7 @@ export const AddEditAllocationModal = ({
onOk: (split: AddEditAllocationModalEntity) => void
onCancel: VoidFunction
hideProjectOwnerOption?: boolean
hideFee?: boolean
}) => {
const { primaryETHTerminalFee } = useContext(V2V3ProjectContext)

Expand All @@ -81,7 +83,8 @@ export const AddEditAllocationModal = ({

const amount = Form.useWatch('amount', form)

const showFee = amountType === 'amount' && recipient === 'walletAddress'
const showFee =
amountType === 'amount' && recipient === 'walletAddress' && !hideFee

const isValidJuiceboxProject = useMemo(
() =>
Expand Down
6 changes: 3 additions & 3 deletions src/locales/messages.pot
Original file line number Diff line number Diff line change
Expand Up @@ -2522,6 +2522,9 @@ msgstr ""
msgid "Deploy an address which forwards ETH to your project. This makes it easier to pay your project with third-party tools."
msgstr ""

msgid "Remaining (to project owner)"
msgstr ""

msgid "Ethereum wallet address"
msgstr ""

Expand Down Expand Up @@ -4505,9 +4508,6 @@ msgstr ""
msgid "There's nothing here"
msgstr ""

msgid "Remaining balance (Project Owner)"
msgstr ""

msgid "Locked cycles"
msgstr ""

Expand Down

2 comments on commit b309c81

@vercel
Copy link

@vercel vercel bot commented on b309c81 Sep 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vercel
Copy link

@vercel vercel bot commented on b309c81 Sep 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.