feat: remove onchain gov from nfts

jbx-protocol · May 26, 2024 · 8901b28 · 8901b28
1 parent 9be04bd
commit 8901b28
Show file tree

Hide file tree

Showing 8 changed files with 7 additions and 167 deletions.
diff --git a/src/components/Create/components/pages/NftRewards/hooks/useCreateFlowNftRewardsForm.ts b/src/components/Create/components/pages/NftRewards/hooks/useCreateFlowNftRewardsForm.ts
@@ -1,6 +1,6 @@
 import { Form } from 'antd'
 import { NftRewardsFormProps } from 'components/NftRewards/AddNftCollectionForm/AddNftCollectionForm'
-import { JB721GovernanceType, NftRewardTier } from 'models/nftRewards'
+import { NftRewardTier } from 'models/nftRewards'
 import { useEffect, useMemo } from 'react'
 import { useAppDispatch } from 'redux/hooks/useAppDispatch'
 import { useAppSelector } from 'redux/hooks/useAppSelector'
@@ -136,23 +136,6 @@ export const useCreateFlowNftRewardsForm = () => {
     },
   })
 
-  useFormDispatchWatch({
-    form,
-    fieldName: 'onChainGovernance',
-    ignoreUndefined: true,
-    dispatchFunction: editingV2ProjectActions.setNftRewardsGovernance,
-    formatter: v => {
-      if (
-        !v ||
-        typeof v === 'string' ||
-        typeof v === 'object' ||
-        typeof v === 'boolean'
-      )
-        return JB721GovernanceType.NONE
-      return v
-    },
-  })
-
   useFormDispatchWatch({
     form,
     fieldName: 'useDataSourceForRedeem',

diff --git a/...omponents/Create/components/pages/ReviewDeploy/components/RewardsReview/RewardsReview.tsx b/...omponents/Create/components/pages/ReviewDeploy/components/RewardsReview/RewardsReview.tsx
@@ -1,6 +1,6 @@
 import { t } from '@lingui/macro'
 import { RewardsList } from 'components/NftRewards/RewardsList/RewardsList'
-import { JB721GovernanceType, NftRewardTier } from 'models/nftRewards'
+import { NftRewardTier } from 'models/nftRewards'
 import { useCallback, useMemo } from 'react'
 import { useAppDispatch } from 'redux/hooks/useAppDispatch'
 import { useAppSelector } from 'redux/hooks/useAppSelector'
@@ -11,7 +11,7 @@ import { ReviewDescription } from '../ReviewDescription'
 
 export const RewardsReview = () => {
   const {
-    nftRewards: { rewardTiers, flags, governanceType },
+    nftRewards: { rewardTiers, flags },
     fundingCycleMetadata,
   } = useAppSelector(state => state.editingV2Project)
 
@@ -66,16 +66,6 @@ export const RewardsReview = () => {
     return formatEnabled(flags.preventOverspending)
   }, [flags.preventOverspending])
 
-  const onChainGovernance = useMemo(() => {
-    switch (governanceType) {
-      case JB721GovernanceType.ONCHAIN:
-        return t`Standard`
-      case JB721GovernanceType.NONE:
-      default:
-        return t`None`
-    }
-  }, [governanceType])
-
   return (
     <div className="flex flex-col gap-12">
       <RewardsList value={rewards} onChange={setRewards} />
@@ -88,12 +78,6 @@ export const RewardsReview = () => {
             </div>
           }
         />
-        <ReviewDescription
-          title={t`On-chain governance type`}
-          desc={
-            <div className="text-base font-medium">{onChainGovernance}</div>
-          }
-        />
         <ReviewDescription
           title={t`Prevent NFT overspending`}
           desc={

diff --git a/src/components/NftRewards/AddNftCollectionForm/AddNftCollectionForm.tsx b/src/components/NftRewards/AddNftCollectionForm/AddNftCollectionForm.tsx
@@ -1,15 +1,12 @@
 import { RightOutlined } from '@ant-design/icons'
 import { Trans, t } from '@lingui/macro'
-import { Form, FormInstance, Radio } from 'antd'
+import { Form, FormInstance } from 'antd'
 import { useLockPageRulesWrapper } from 'components/Create/hooks/useLockPageRulesWrapper'
 import ExternalLink from 'components/ExternalLink'
 import TooltipLabel from 'components/TooltipLabel'
 import { JuiceInput } from 'components/inputs/JuiceTextInput'
-import { RadioItem } from 'components/inputs/RadioItem'
-import { JB721GovernanceType, NftRewardTier } from 'models/nftRewards'
+import { NftRewardTier } from 'models/nftRewards'
 import { inputMustExistRule } from 'utils/antdRules'
-import { helpPagePath } from 'utils/routes'
-import { CreateBadge } from '../../Create/components/CreateBadge'
 import { CreateCollapse } from '../../Create/components/CreateCollapse/CreateCollapse'
 import { OptionalHeader } from '../../Create/components/OptionalHeader'
 import { RewardsList } from '../RewardsList/RewardsList'
@@ -24,7 +21,6 @@ export type NftRewardsFormProps = Partial<{
   postPayMessage?: string
   postPayButtonText?: string
   postPayButtonLink?: string
-  onChainGovernance: JB721GovernanceType
   useDataSourceForRedeem: boolean
   preventOverspending: boolean
 }>
@@ -121,43 +117,6 @@ export const AddNftCollectionForm = ({
               </Form.Item>
 
               <CreateCollapse>
-                <CreateCollapse.Panel
-                  key={1}
-                  header={<OptionalHeader header={t`On-chain Governance`} />}
-                  hideDivider
-                >
-                  <Form.Item name="onChainGovernance">
-                    <Radio.Group className="flex flex-col gap-5">
-                      <RadioItem
-                        value={JB721GovernanceType.NONE}
-                        title={
-                          <div className="flex items-center gap-3">
-                            <Trans>No on-chain governance</Trans>{' '}
-                            <CreateBadge.Default />
-                          </div>
-                        }
-                        description={t`Your project's NFTs will not have on-chain governance capabilities. Select this option if you don't want governance, or if you plan to use an off-chain voting client (like Snapshot).`}
-                      />
-                      <RadioItem
-                        value={JB721GovernanceType.ONCHAIN}
-                        title={t`Standard on-chain governance`}
-                        description={
-                          <Trans>
-                            Track the total voting power of each address over
-                            time.{' '}
-                            <ExternalLink
-                              href={helpPagePath(
-                                '/user/configuration/#on-chain-governance',
-                              )}
-                            >
-                              Learn more.
-                            </ExternalLink>
-                          </Trans>
-                        }
-                      />
-                    </Radio.Group>
-                  </Form.Item>
-                </CreateCollapse.Panel>
                 <CreateCollapse.Panel
                   key={2}
                   header={<OptionalHeader header={t`Payment Success Pop-up`} />}

diff --git a/src/components/NftRewards/RewardsList/AddEditRewardModal.tsx b/src/components/NftRewards/RewardsList/AddEditRewardModal.tsx
@@ -337,26 +337,6 @@ export const AddEditRewardModal = ({
                 </Form.Item>
               </>
             )}
-            <Form.Item
-              name="votingWeight"
-              label={t`Voting weight`}
-              extra={t`Give this NFT a voting weight to be used for on-chain governance. The number you set is only used in relation to other NFTs in this collection.`}
-              tooltip={
-                <Trans>
-                  If you use the default governance option (no governance), the
-                  voting weight will still be accessible on the blockchain for
-                  use in Snapshot strategies or any other desired purpose.
-                </Trans>
-              }
-              rules={[
-                inputIsIntegerRule({
-                  label: t`Voting weight`,
-                  stringOkay: true,
-                }),
-              ]}
-            >
-              <FormattedNumberInput />
-            </Form.Item>
             <Form.Item
               name="externalUrl"
               label={t`External link`}

diff --git a/...ect/V2V3ProjectSettings/pages/EditNftsPage/LaunchNftCollection/hooks/useLaunchNftsForm.ts b/...ect/V2V3ProjectSettings/pages/EditNftsPage/LaunchNftCollection/hooks/useLaunchNftsForm.ts
@@ -100,8 +100,7 @@ export const useLaunchNftsForm = () => {
             formValues.preventOverspending ??
             DEFAULT_NFT_FLAGS.preventOverspending,
         },
-        governanceType:
-          formValues.onChainGovernance ?? JB721GovernanceType.NONE,
+        governanceType: JB721GovernanceType.NONE,
         pricing: DEFAULT_NFT_PRICING, // TODO add to form
       },
       editingMustStartAtOrAfter,

diff --git a/...ct/V2V3ProjectSettings/pages/EditNftsPage/UpdateNftsPage/EditCollectionDetailsSection.tsx b/...ct/V2V3ProjectSettings/pages/EditNftsPage/UpdateNftsPage/EditCollectionDetailsSection.tsx
@@ -69,16 +69,11 @@ export function EditCollectionDetailsSection() {
       'collectionSymbol',
       initialValues.collectionSymbol,
     )
-    const onchainGovernanceChanged = hasChanged(
-      'onChainGovernance',
-      initialValues.onChainGovernance,
-    )
 
     const hasUpdated =
       collectionNameChanged ||
       collectionDescriptionChanged ||
-      collectionSymbolChanged ||
-      onchainGovernanceChanged
+      collectionSymbolChanged
 
     setFormHasUpdated(hasUpdated)
   }, [marketplaceForm, initialValues, setFormHasUpdated])

diff --git a/...ents/v2v3/V2V3Project/V2V3ProjectSettings/pages/EditNftsPage/UpdateNftsPage/formFields.ts b/...ents/v2v3/V2V3Project/V2V3ProjectSettings/pages/EditNftsPage/UpdateNftsPage/formFields.ts
@@ -1,8 +1,5 @@
-import { JB721GovernanceType } from 'models/nftRewards'
-
 export type MarketplaceFormFields = {
   collectionName: string
   collectionSymbol: string
   collectionDescription: string
-  onChainGovernance: JB721GovernanceType
 }