fix: catch errors when ens lookup fails on address input

jbx-protocol · Sep 23, 2024 · 64897e3 · 64897e3
1 parent c23b15b
commit 64897e3
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 8 deletions.
diff --git a/src/components/inputs/EthAddressInput.tsx b/src/components/inputs/EthAddressInput.tsx
@@ -48,8 +48,8 @@ export function EthAddressInput({
     async (address: string) => {
       onChange?.(address)
 
-      const ensNameForAddress = await resolveAddress(address)
-      if (ensNameForAddress.name) {
+      const ensNameForAddress = await resolveAddress(address).catch(() => {}) // noop, ignore errors
+      if (ensNameForAddress?.name) {
         setENSName(ensNameForAddress.name)
         setAddressForENSName(address)
       }

diff --git a/src/pages/api/auth/challenge-message.ts b/src/pages/api/auth/challenge-message.ts
@@ -14,8 +14,10 @@ const WalletSigningRequestMessageTemplate = template(
  */
 const handler = async (req: NextApiRequest, res: NextApiResponse) => {
   try {
-    if (req.method !== 'GET')
+    if (req.method !== 'GET') {
       return res.status(405).json({ message: 'Method not allowed.' })
+    }
+
     const { walletAddress } = req.query ?? {}
     if (!walletAddress || typeof walletAddress !== 'string') {
       return res.status(400).json({ message: 'Invalid request.' })

diff --git a/src/pages/api/ens/resolve/[address].ts b/src/pages/api/ens/resolve/[address].ts
@@ -9,7 +9,7 @@ const logger = getLogger('api/ens/resolve/[address]')
 
 const handler = async (req: NextApiRequest, res: NextApiResponse) => {
   if (req.method !== 'GET') {
-    return res.status(404)
+    return res.status(405).end()
   }
 
   try {
@@ -20,7 +20,7 @@ const handler = async (req: NextApiRequest, res: NextApiResponse) => {
 
     if (readNetwork.name === NetworkName.sepolia) {
       // ethers v5 doesn't support ens on sepolia
-      return res.status(404).json({ error: 'ens not supported on sepolia' })
+      return res.status(400).json({ error: 'ens not supported on sepolia' })
     }
 
     let response

diff --git a/src/pages/api/juicebox/jb-721-delegate/[dataSourceAddress].ts b/src/pages/api/juicebox/jb-721-delegate/[dataSourceAddress].ts
@@ -180,7 +180,7 @@ const handler = async (req: NextApiRequest, res: NextApiResponse) => {
   enableCors(res)
 
   if (req.method !== 'GET') {
-    return res.status(404)
+    return res.status(405).end()
   }
 
   try {

diff --git a/src/pages/api/juicebox/prices/ethusd.ts b/src/pages/api/juicebox/prices/ethusd.ts
@@ -17,7 +17,7 @@ const handler = async (req: NextApiRequest, res: NextApiResponse) => {
   enableCors(res)
 
   if (req.method !== 'GET') {
-    return res.status(404)
+    return res.status(405).end()
   }
 
   try {

diff --git a/src/pages/api/juicebox/projectHandle/[projectId].ts b/src/pages/api/juicebox/projectHandle/[projectId].ts
@@ -9,7 +9,7 @@ const logger = getLogger('api/juicebox/projectHandle/[projectId]')
 
 const handler = async (req: NextApiRequest, res: NextApiResponse) => {
   if (req.method !== 'GET') {
-    return res.status(404).json({ error: 'not found' })
+    return res.status(405).json({ error: 'method not supported' })
   }
 
   try {