Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix after 4.29.0.Final release #2118

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Fix after 4.29.0.Final release #2118

merged 2 commits into from
Nov 3, 2023

Conversation

sbouchet
Copy link
Contributor

@sbouchet sbouchet commented Nov 3, 2023

Pull Request Checklist

General

  • Is this a blocking issue or new feature? If yes, QE needs to +1 this PR

Code

  • Are method-/class-/variable-names meaningful?
  • Are methods concise, not too long?
  • Are catch blocks catching precise Exceptions only (no catch all)?

Testing

  • Are there unit-tests?
  • Are there integration tests (or at least a jira to tackle these)?
  • Is the non-happy path working, too?
  • Are other parts that use the same component still working fine?

Function

  • Does it work?

@sbouchet sbouchet merged commit bb403de into jbosstools:main Nov 3, 2023
4 checks passed
@sbouchet sbouchet deleted the Fix_after_4.29.0.Final_release branch November 3, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sbouchet