Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition in test #198

Merged
merged 1 commit into from
Oct 3, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -146,16 +146,29 @@ public void testFixedDelayExecution() throws Exception {
@Test
public void testThatFixedDelayTerminatesTask() {
EnhancedQueueExecutor eqe = new EnhancedQueueExecutor.Builder().build();
final ArrayList<LocalDateTime> times = new ArrayList<>();
var r = new Runnable() {
final ScheduledFuture<?> future = eqe.scheduleWithFixedDelay(this, 0, 100, TimeUnit.MILLISECONDS);
final ArrayList<LocalDateTime> times = new ArrayList<>();
final CountDownLatch latch = new CountDownLatch(1);
volatile ScheduledFuture<?> future;

public void run() {
times.add(LocalDateTime.now());
if (times.size() >= 5) {
try {
latch.await();
} catch (InterruptedException e) {
throw new RuntimeException(e);
}
future.cancel(false);
}
}

public void schedule() {
future = eqe.scheduleWithFixedDelay(this, 0, 100, TimeUnit.MILLISECONDS);
}
};
r.schedule();
r.latch.countDown();
assertThrows(CancellationException.class, () -> r.future.get(5, TimeUnit.SECONDS));
}

Expand Down