Move unshared fields to arrays #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@franz1981 WDYT? Is this reasonable? |
|
looking bud @dmlloyd ! |
franz1981
reviewed
May 2, 2024
The arrays can then be sized based on the run time cache line size, allowing better parallelism on CPUs with long cache lines.
|
Also, move the queue size field to an unshared memory location since it is also frequently updated. |
|
This does need to be tested with a native build on Quarkus before merging. |
|
Seems to work! ✅ |
|
Sorry for the late approval @dmlloyd but is good, well done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The arrays can then be sized based on the run time cache line size, allowing better parallelism on CPUs with long cache lines.