Add Record and PermittedSubclasses (sealed) Attributes #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the Java 17 Record and PermittedSubclasses (for sealed classes and interfaces) Attributes to Javassist. These are very much needed as soon as possible for a remapper i have https://pagure.io/AssistRemapper/tree/main which i need to remap classes and records but have been unable to fully do so because Javassist did not yet have the attributes built in so i decided to add them to fix these issues.
Here is the test project. Simply add javassist as a dependency. I did not include it in the official JA test suite because it is based on Java 11 while the attributes i added were for later versions.
https://github.com/Asbestosstar/javassistrecordsealedtests
Please let me know what changes need to be made