Tests for corner cases in MP FT integration with Micrometer and MP Telemetry #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiobrz
force-pushed
the
eapqe-2736.more-ft-metrics-tests
branch
from
4dacffd to
472ffa6
Compare
fabiobrz
changed the title
fabiobrz
force-pushed
the
eapqe-2736.more-ft-metrics-tests
branch
from
472ffa6 to
39838f6
Compare
6 tasks
fabiobrz
force-pushed
the
eapqe-2736.more-ft-metrics-tests
branch
from
39838f6 to
4b1d0f8
Compare
marekkopecky
reviewed
Dec 3, 2024
...ss/eap/qe/microprofile/fault/tolerance/integration/metrics/MultipleMetricsExtensionTest.java
Show resolved
Hide resolved
marekkopecky
reviewed
Dec 3, 2024
...ss/eap/qe/microprofile/fault/tolerance/integration/metrics/MultipleMetricsExtensionTest.java
Outdated
Show resolved
Hide resolved
marekkopecky
reviewed
Dec 3, 2024
...src/main/java/org/jboss/eap/qe/observability/containers/OpenTelemetryCollectorContainer.java
Show resolved
Hide resolved
|
Just a few minor comments, otherwise LGTM |
fabiobrz
force-pushed
the
eapqe-2736.more-ft-metrics-tests
branch
2 times, most recently
from
f359eb8 to
6853ae5
Compare
…oth Micrometer and MP Telemetry corner cases for MP Fault Tolerance Fixing MicroProfileTelemetryServerSetup.java and renaming it to MicroProfileTelemetryServerConfiguration.java. Fix OpenTelemetryCollectorContainer and improve it, so that it can now provide new instance, and does not handle the Jaeger container lifecycle anymore
fabiobrz
force-pushed
the
eapqe-2736.more-ft-metrics-tests
branch
from
6853ae5 to
aae22eb
Compare
Hi @marekkopecky - I've addressed al of your comments above, and validation runs are ok, being the |
|
Thank you for the discussion here, all threads are resolved, merging. |
marekkopecky
approved these changes
Dec 4, 2024
This was referenced Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSIA
Resolves #317
Validation job runs:
https://github.com/fabiobrz/eap-microprofile-test-suite/actions/runs/12135061804https://github.com/fabiobrz/eap-microprofile-test-suite/actions/runs/12142399569https://github.com/jboss-eap-qe/eap-microprofile-test-suite/actions/runs/12142663575 - 1 failure inDatabaseCrashTestis unrelatedhttps://github.com/fabiobrz/eap-microprofile-test-suite/actions/runs/12135055664https://github.com/fabiobrz/eap-microprofile-test-suite/actions/runs/12142389442https://github.com/jboss-eap-qe/eap-microprofile-test-suite/actions/runs/12142663573 - 1 failure inDatabaseCrashTestis unrelatedPlease make sure your PR meets the following requirements: