-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MicroProfile OpenAPI tests for v4.0. #313
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR @pferraro. I am wondering whether this is enough, since we should actually bump the MicroProfile spec version in the POM to 7, see https://github.com/pferraro/eap-microprofile-test-suite/blob/master/pom.xml#L52.
This change was committed recently, so a rebase on upstream master branch would do.
Then we need to see whether the tests actually pass, which can be done via a manual workflow execution..
I explicitly omitted that version bump from the commit since it breaks other tests in the suite (as those modules are not yet MP7 ready). |
Oops. I missed that vital detail the first time... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parameterized test artifacts for future ease of future upgrades.