Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MicroProfile OpenAPI tests for v4.0. #313

Merged
merged 4 commits into from
Nov 15, 2024

Conversation

pferraro
Copy link
Contributor

Parameterized test artifacts for future ease of future upgrades.

Copy link
Member

@fabiobrz fabiobrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @pferraro. I am wondering whether this is enough, since we should actually bump the MicroProfile spec version in the POM to 7, see https://github.com/pferraro/eap-microprofile-test-suite/blob/master/pom.xml#L52.
This change was committed recently, so a rebase on upstream master branch would do.

Then we need to see whether the tests actually pass, which can be done via a manual workflow execution..

@fabiobrz fabiobrz self-assigned this Nov 15, 2024
@pferraro
Copy link
Contributor Author

Thanks for this PR @pferraro. I am wondering whether this is enough, since we should actually bump the MicroProfile spec version in the POM to 7, see https://github.com/pferraro/eap-microprofile-test-suite/blob/master/pom.xml#L52. This change was committed recently, so a rebase on upstream master branch would do.

Then we need to see whether the tests actually pass, which can be done via a manual workflow execution..

I explicitly omitted that version bump from the commit since it breaks other tests in the suite (as those modules are not yet MP7 ready).
Rather, what can do is override the version of the MP OpenAPI spec for this test module only.

@pferraro
Copy link
Contributor Author

This change was committed recently, so a rebase on upstream master branch would do.

Oops. I missed that vital detail the first time...

Copy link
Member

@fabiobrz fabiobrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, thanks @pferraro! Also for cleaning up the dependencies.
Tests are green here against the mp-7-wip branch.
Merging!

@fabiobrz fabiobrz merged commit fe9265a into jboss-eap-qe:master Nov 15, 2024
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants