Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issues-301] - Add a GitHub workflow to run integration tests against the default WildFly version #304

Merged
merged 5 commits into from
Oct 18, 2024

Conversation

fabiobrz
Copy link
Member

@fabiobrz fabiobrz commented Oct 16, 2024

This is for running automated CI checks against the WildFly version which is set by related properties default values, in order to implement CI checks upstream.

Resolves #301


Please make sure your PR meets the following requirements:

  • Pull Request contains a description of the changes
  • Pull Request does not include fixes for multiple issues/topics
  • Code is formatted, imports ordered, code compiles and tests are passing
  • N/A Link to the passing job is provided
  • Code is self-descriptive and/or documented
  • N/A Description of the tests scenarios is included (see Update PR template to include TPG stuff #46)

@fabiobrz fabiobrz force-pushed the issues-301.add-wildfly-it-workflow branch 7 times, most recently from d18b7f2 to 20851bd Compare October 17, 2024 14:52
@fabiobrz fabiobrz requested a review from jbliznak October 17, 2024 14:52
@fabiobrz
Copy link
Member Author

@jbliznak would you mind and have another look please? I've added the bootable JAR execution and fixed some minor things, but IMHO this should be enough for PRs.

@fabiobrz fabiobrz force-pushed the issues-301.add-wildfly-it-workflow branch 2 times, most recently from f201023 to 3f9b676 Compare October 17, 2024 15:41
@fabiobrz fabiobrz marked this pull request as draft October 17, 2024 15:46
@fabiobrz fabiobrz force-pushed the issues-301.add-wildfly-it-workflow branch from 3f9b676 to 922d785 Compare October 17, 2024 15:48
@fabiobrz
Copy link
Member Author

IMHO this should be enough for PRs.

FYI @jbliznak - I am back to draft since I noticed that surefire reports aren't uploaded. Will have to look into that and then I'll ping you again.

pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@fabiobrz fabiobrz force-pushed the issues-301.add-wildfly-it-workflow branch from 7dbf6f0 to c12d89e Compare October 18, 2024 07:08
@fabiobrz fabiobrz marked this pull request as ready for review October 18, 2024 07:08
@fabiobrz fabiobrz force-pushed the issues-301.add-wildfly-it-workflow branch from c12d89e to 7d51ebf Compare October 18, 2024 07:16
@fabiobrz fabiobrz requested a review from jbliznak October 18, 2024 07:31
fabiobrz and others added 5 commits October 18, 2024 10:50
… a WildFly version defined by default properties
… a WildFly bootable JAR version defined by default properties
…ies in order to deal with changes in transitively pulled dependencies
…ak container started by JWT tests, since it generates huge logs, and it's not needed now
@fabiobrz fabiobrz force-pushed the issues-301.add-wildfly-it-workflow branch from 7d51ebf to 5722d49 Compare October 18, 2024 08:51
@fabiobrz fabiobrz requested a review from jbliznak October 18, 2024 09:35
@jbliznak jbliznak merged commit dced660 into master Oct 18, 2024
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement GitHub workflow based CI checks for PR changes
2 participants