This repository has been archived by the owner on Aug 5, 2018. It is now read-only.
Master #5
Open
Master #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of trying to shoehorn these fields into the passenger table, it makes sense to use the fields on the reservation as user input. A `Passenger` corresponds to the response from SW that contains each passenger on the reservation. Therefore, first and last name exist in the reservations and passengers table, but server different roles: user input and SW data, respectively.
…thwest::Reservations
- makes the API easier to use
- add various validations and validation specs - add various relationships
- remove unnecessary HTTP requests from checkin - refactor tests so it is easier to test different scenarios - extract flight numbers with regex - handle error cases, i.e. cancelled reservations
Fix multi-passenger parser error, support upstart jobs, disable syslogger
Enable international flights
fix dev:rake tests for international flights
Notify on international flights, use alternative flight number field
Order reservations by departure time
Update README.md for Debian 7 x64 install
* fix: checkin all passengers on multi-passenger reservations * test: validate single-confirmation, multi-passenger reservation with a test
* feat: provide sidekiq a short polling interval for faster checkins This also removes the 1 second `scheduled_at` delay in favor of relying on the slight delay in polling. * wip: update test for the removed delay * feat: robots.txt
…ique Make confirmation numbers unique until they are completed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make confirmation numbers unique until they are completed