Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore legacy C++ implementations #492

Merged
merged 3 commits into from
Jan 12, 2025
Merged

Conversation

jbcoe
Copy link
Owner

@jbcoe jbcoe commented Jan 12, 2025

No description provided.

Base automatically changed from dev-jbcoe-update-impl-for-constraints to main January 12, 2025 17:11
@jbcoe jbcoe marked this pull request as ready for review January 12, 2025 17:11
@jbcoe jbcoe requested a review from Twon as a code owner January 12, 2025 17:11
Copy link

codecov bot commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 99.43020% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.55%. Comparing base (0a710d2) to head (8a064b5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
polymorphic_cxx14.h 98.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #492      +/-   ##
==========================================
- Coverage   99.68%   99.55%   -0.14%     
==========================================
  Files           5        7       +2     
  Lines         316      669     +353     
  Branches       31       75      +44     
==========================================
+ Hits          315      666     +351     
- Misses          1        3       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Twon Twon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to see these types reinstated

@jbcoe jbcoe merged commit ac122c2 into main Jan 12, 2025
30 of 32 checks passed
@jbcoe jbcoe deleted the dev-jbcoe-restore-legacy-cxx-impls branch January 12, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants