Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update icalparser.py #73

Closed
wants to merge 1 commit into from
Closed

Conversation

dkuschmierz
Copy link

Resetting start and end date while walking the calendar. This prevents that some events are missing if there is an all_day-Event in between some events.

Consider the following settings:
startdate: 01.12.2020 00:00:00
enddate: 31.12.2020 23:59:59

Events:
10.12.2020 18:00:00 EventA
22.12.2020 AllDay EventB
31.12.2020 17:00:00 EventC

While iterating through the calendar, the enddate-settings are reseted during the allday-event to 31.12.2020 00:00:00 and then EventC is missing in the list!

Resetting start and end date while walking the calendar. This prevents that some events are missing if there is an all_day-Event in between some events.

Consider the following settings:
  startdate: 01.12.2020 00:00:00
  enddate: 31.12.2020 23:59:59
  
  Events:
  10.12.2020 18:00:00 EventA
  22.12.2020 AllDay     EventB
  31.12.2020 17:00:00 EventC

While iterating through the calendar, the enddate-settings are reseted during the allday-event to 31.12.2020 00:00:00 and then EventC is missing in the list!
@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #73 into master will decrease coverage by 1.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
- Coverage   82.82%   81.70%   -1.12%     
==========================================
  Files           4        4              
  Lines         326      328       +2     
  Branches       77       77              
==========================================
- Hits          270      268       -2     
- Misses         31       33       +2     
- Partials       25       27       +2     
Impacted Files Coverage Δ
icalevents/icalparser.py 81.58% <100.00%> (-1.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce0581e...1069241. Read the comment docs.

@Hultner
Copy link
Member

Hultner commented Oct 27, 2020

Resetting start and end date while walking the calendar. This prevents that some events are missing if there is an all_day-Event in between some events.

Consider the following settings:
startdate: 01.12.2020 00:00:00
enddate: 31.12.2020 23:59:59

Events:
10.12.2020 18:00:00 EventA
22.12.2020 AllDay EventB
31.12.2020 17:00:00 EventC

While iterating through the calendar, the enddate-settings are reseted during the allday-event to 31.12.2020 00:00:00 and then EventC is missing in the list!

Thanks for the contribution :)
Could you formalise the behaviour you change in a test?

@eigenmannmartin
Copy link
Member

eigenmannmartin commented Sep 9, 2024

If I understand correctly this is solved here: #136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants