Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #527 history button not working #1402

Merged

Conversation

trumpet2012
Copy link
Contributor

Description

This PR fixes the history button that gets shown when viewing a historical version of a model so that it correctly links back to the history listing for that object.

Related Issue

#527

Motivation and Context

Fixes a broken link that users expect to work.

How Has This Been Tested?

I tested this by installing it as a development dependency in our django project. I also ran make tests however only the sqlite versions worked since I haven't setup postgres/msql locally.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run the pre-commit run command to format and lint.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have added my name and/or github handle to AUTHORS.rst
  • I have added my change to CHANGES.rst
  • All new and existing tests passed.

tim-schilling
tim-schilling previously approved these changes Dec 5, 2024
Copy link
Contributor

@tim-schilling tim-schilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Thank you @trumpet2012 for your patience

@tim-schilling
Copy link
Contributor

I found another way to do this.

We could define a template at templates/admin/change_form_object_tools.html and if the simple_history app is installed before the admin, it allows us to override the template without having to override that block.

However, I think the additional installation requirements are a bit too burdensome.

@tim-schilling tim-schilling merged commit b890718 into jazzband:master Dec 5, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants