-
-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deferred fields patch #1393
Deferred fields patch #1393
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
I wanted to work on a new feature so I needed to branch my fork and re-submit this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @JordanHyatt. I apologize for taking so long to get to this. I think once it's cleaned up, it's an easy thing for us to merge in.
All requested changes have been pushed! (except for maybe the signals.rst issue?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your help!
…-simple-history into deferred-fields-patch
@tim-schilling sorry I added in a last second piece of logic that will skip loading the fields if its not a history enabled model. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1393 +/- ##
==========================================
- Coverage 96.81% 96.73% -0.09%
==========================================
Files 24 24
Lines 1446 1470 +24
Branches 236 240 +4
==========================================
+ Hits 1400 1422 +22
Misses 25 25
- Partials 21 23 +2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
I think we are about there, let me know what you think @tim-schilling! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Description
Provided a patch that allows objects to be deleted when they have deferred fields present
Related Issue
This is related to issue #678
Motivation and Context
This allows users of simple_history to delete objects without having to consider the consequences of deferring fields in their query
Types of changes
Checklist:
pre-commit run
command to format and lint.AUTHORS.rst
CHANGES.rst