Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dependabot not creating new dependency PRs #1332

Merged
merged 1 commit into from
May 15, 2024

Conversation

ddabble
Copy link
Member

@ddabble ddabble commented May 14, 2024

Description

Error message from Dependabot:

Dependabot couldn't fetch all your path-based dependencies
The affected dependencies were "-e ." at /requirements/docs.txt.

To use path-based dependencies with Dependabot the paths must be relative, resolve to a directory in this project's source code, and contain a valid Python project.

(Prompted by visiting Dependency graph -> Dependabot -> "Recent update jobs" next to requirements/coverage.txt -> "Check for updates".)

The fix simply moves installing the project locally from requirements/docs.txt to .readthedocs.yaml (not in editable mode (-e) anymore, but the build still succeeds - see below).

Related Issue

None

Motivation and Context

No new Dependabot PRs for our pip packages have been created for many months, leaving multiple packages outdated.

Context for the removed lines: bd26f19

How Has This Been Tested?

Evidence that RTD still builds successfully (for the commit ddabble@aa5e062)

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run the pre-commit run command to format and lint.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have added my name and/or github handle to AUTHORS.rst
  • I have added my change to CHANGES.rst
  • All new and existing tests passed.

Context: bd26f19

This (refactor, technically) was motivated by fixing a Dependabot error
that prevented it from creating new dependency PRs.
Error message:

> **Dependabot couldn't fetch all your path-based dependencies**
> The affected dependencies were `"-e ." at /requirements/docs.txt`.
>
> To use path-based dependencies with Dependabot the paths must be relative, resolve to a directory in this project's source code, and contain a valid Python project.

(From https://github.com/jazzband/django-simple-history/network/updates/827989501.)

Evidence that RTD still builds successfully:
https://readthedocs.org/projects/ddabble-django-simple-history/builds/24379182/
@ddabble ddabble requested a review from tim-schilling May 14, 2024 19:39
@ddabble ddabble merged commit 87327ce into master May 15, 2024
38 checks passed
@ddabble ddabble deleted the fix/dependabot-fetching-error branch May 15, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants