-
-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
History view pagination #1277
History view pagination #1277
Conversation
Any update on this? Do you need any help? |
@ddabble ? |
@jurrian Sorry for the (very) late reply; I'm busy with some of the other PRs, currently, but this is definitely on my TODO list 🙂 |
Hi guys! How is going this feature? I'm super engaged with that, for us would be an amazing deliveryHi guys! How is going this feature? I'm super engaged with that for us will be an amazing delivery |
Only needs review at the moment. Code should be complete, but needs to be tested and merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. It seems like it's a bit old now and needs to be rebased on main. Is that something you may have time for yet?
41a24bd
to
78e10ce
Compare
@tim-schilling I have done the rebase and did some minor tweaks. Most notably |
Borrowed from Django's object_history.html
78e10ce
to
2b45e85
Compare
This avoids performing any database queries before we know that the user should be able to view data.
A developer is more likely to look for the term page size.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Thank you @jurrian!
Description
This will add pagination and filtering to the simple history admin view. This is needed because it will allow more performance views on instances with many historical records. Currently it is very likely to timeout depending on the settings.
It uses the same pagination as the default in Django.
Related Issue
This PR replaces this stale PR: #1220
Most of the text of this PR is copied from the stale one.
Closes #1117 and closes #1219.
Motivation and Context
This is needed because it will allow more performance views on instances with many historical records. Currently it is very likely to timeout depending on the settings .
How Has This Been Tested?
Added a few extra tests on top of what already existed in the stale PR.
Screenshots (if appropriate):
Types of changes
Checklist:
pre-commit run
command to format and lint.AUTHORS.rst
CHANGES.rst