-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge #6
base: master
Are you sure you want to change the base?
merge #6
Conversation
This reverts commit ca9e80e.
Conflicts: audioservers-api/pom.xml audioservers-jack/pom.xml audioservers-javasound/pom.xml
https://git.oschina.net/nybbs2003/audioservers.git Conflicts: audioservers-api/.classpath audioservers-api/pom.xml
- updated maven-compiler-plugin settings to: 1) use the most recent version; 2) set source and target versions to 1.8 (b/c 1.5 is no longer supported.
Resolve Conflicts
Hi! Thanks for your interest in the library. However, I can't merge this as is. I may look at cherry-picking certain things, or we can look at multiple PRs for them, but there are quite a few things that can't be pulled in as is. The Jack / JavaSound MIDI interfacing is nice, although I'm not sure where is best to include it given future of Java modules - be good if JACK didn't require java.desktop
|
Thank you for your (quick) reply. |
Thanks!
But adding in javax.sound.midi support would add a java.desktop requirement. That's why I wonder whether to put that code elsewhere.
In which case, a link to a repository in your account would be a good start. I'll have another look at the whole headers situation, and we can look at forking it over into the JAudioLibs space later? I'll also look at publishing the audioservers to Maven Central (JNAJack is already there). I'm currently looking at another backend using the GStreamer bindings, so be good to get some more activity here again - I've not worked on much of this for years now! |
No description provided.