Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge #6

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

merge #6

wants to merge 30 commits into from

Conversation

nybbs2003
Copy link

No description provided.

@neilcsmith-net
Copy link
Member

Hi! Thanks for your interest in the library. However, I can't merge this as is. I may look at cherry-picking certain things, or we can look at multiple PRs for them, but there are quite a few things that can't be pulled in as is. The Jack / JavaSound MIDI interfacing is nice, although I'm not sure where is best to include it given future of Java modules - be good if JACK didn't require java.desktop

  • The ASIO server can't be included here because of licensing issues with the headers. I'm happy to consider publishing links to your code or a separate repository here?
  • Eclipse configuration and various binary files (DS-Store) don't belong in the repository.
  • AudioConfiguration is not intended to be Serializable and doesn't really work correctly if it is. Serialization is also in the process of being removed from the JDK. Create a serialization wrapper if you need one.
  • AudioClient can't usefully be a functional interface.
  • There are other ways of exposing JACK functionality already using the AudioConfiguration lookup.
  • The switch to wait() is wrong.

@nybbs2003
Copy link
Author

Thank you for your (quick) reply.
For JACK:
JACK in itself has no requirement for desktop environment, and can run head-less. In other words, it does not require java.desktop at all.
For ASIO:
I am good with both of the solutions. Either link/separate repository is OK.
else:
It has been long time since I commit some of the changes. And I agree that some of the practices are considered mistake/non-suitable from my today's perspective. However, I would like to make contribution(s) to the open-source project, if there's improvement of the code.

@neilcsmith-net
Copy link
Member

Thanks!

JACK in itself has no requirement for desktop environment, and can run head-less. In other words, it does not require java.desktop at all.

But adding in javax.sound.midi support would add a java.desktop requirement. That's why I wonder whether to put that code elsewhere.

For ASIO: I am good with both of the solutions. Either link/separate repository is OK.

In which case, a link to a repository in your account would be a good start. I'll have another look at the whole headers situation, and we can look at forking it over into the JAudioLibs space later? I'll also look at publishing the audioservers to Maven Central (JNAJack is already there).

I'm currently looking at another backend using the GStreamer bindings, so be good to get some more activity here again - I've not worked on much of this for years now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants