-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JOSE Paper #14
JOSE Paper #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Started adding some suggestions, will hopefully find time for making some changes tomorrow or next week
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great :) Just a couple of very small suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have made a couple of suggestions, but these are more stylistic, so I'm approving as I'm happy for this to go ahead either way. :)
Outstanding tasks:
|
87e4664
to
7ddd953
Compare
OK @MarionBWeinzierl and @AmyOctoCat I think I am pretty much happy with this now (just pushed updates and tweaks, so will come back tomorrow and read fresh after a break). One thought was I wonder if we can cite https://jose.theoj.org/papers/10.21105/jose.00144 somewhere as something that our course here is complementary to - a 'philosophy' component to their 'hard' content. Please could you take a read and see how you feel, and think about how we compare to the submission criteria here: https://openjournals.readthedocs.io/en/jose/submitting.html (paper and repo). @AmyOctoCat feel free not to do anything or look in great detail (though an "I'm still happy to be included" would be appreciated 😄). |
Maybe it could be added in the summary, where the FAIR paper is also cited. Or in the teaching strategy part. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments you might agree or disagree with
Squashing and merging for submission now. |
Upload first draft of JOSE paper [WIP] and CI action to generate online.
I have cherry picked from the summer school repo back to main here as best as I can as this one is the origin.
The one thing I do not have yet is the work on Licenses and Repos - this appears in my git and github workshop, but perhaps it is nice to have in both so they can be more standalone?
Much of the text in the paper is there, with a couple more sections that I need to flesh out.
I have added an action that generates the pdf (see the PR checks below).
Comments or reviews very much appreciated (and PRs).
Other examples of JOSE papers, and submisison guidelines, can be found here: https://jose.theoj.org/papers/published
It would be good if we can all be happy and in a position to submit by 23rd August 2024.
Tagging @MarionBWeinzierl and @AmyOctoCat to review.