adding i18n support #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More specifically:
- adding dependency to TranslationServiceProvider in composer.json
- creating translation messages files under src/SimpleUser/translations/{cultureCode}/*
- loading translation files in src/SimpleUser/UserServiceProvider.php
- externalizing strings in all templates to translation files
- adding language pick dropdown in layout.twig (conditional, only present when more than 1 locale in place)
- updating unit tests
- updating readme.md with how to example
More specifically: 1. UserManager.php - removed escaping part from setColumns - created getCol,umnsEscaped method - it operates on getColumns and applies escaping - changed SQL statements to use getUserColumns and getUserColumnsEscaped where needed - sanitized :param_name 2. UserManagerTest.php - created $app protected property - added test case for custom email column name containing risky character (space). - referencing getUserColumns instead of hardcoded column name in two present testcases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More specifically: