Get tool/cosmocc/package.sh working on M1 #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On aarch64 hosts, MODE= is changed to MODE=aarch64, so o// targets don't work. So On aarch64, get apelink.com out of o/aarch64/. Also prepend ape when calling it. And finally, fetch with curl when wget isn't installed.
jart
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
Looks good to me.
I just need one process hurdle from you first before I can merge. Can
you please send an email to [email protected] saying "I intend to assign
you the copyright to the changes I contribute to Cosmopolitan"? It only
applies to the changes you choose to contribute. It only needs to happen
once. If your employer owns everything you do, then you'll need to clear
it with them first. Please do that if you need to and get it on the
record. Please link to this PR inside your email. Thanks!
|
Done. |
G4Vi
pushed a commit
to G4Vi/cosmopolitan
that referenced
this pull request
Jan 19, 2024
On aarch64 hosts, MODE= is changed to MODE=aarch64, so o// targets don't work. So On aarch64, get apelink.com out of o/aarch64/. Also prepend ape when calling it. And finally, fetch with curl when wget isn't installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On aarch64 hosts, MODE= is changed to MODE=aarch64, so o// targets don't real. So On aarch64, get apelink.com out of o/aarch64/. Also prepend ape when calling it. And finally, fetch with curl when wget isn't installed.