Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux: Add cachestat, fchmodat2 syscalls #958

Merged
merged 5 commits into from
Nov 20, 2023
Merged

Linux: Add cachestat, fchmodat2 syscalls #958

merged 5 commits into from
Nov 20, 2023

Conversation

The-King-of-Toasters
Copy link
Contributor

I haven't wired up fchmodat2 yet, as it's pretty fresh and I wasn't sure to put it in with the fchmodat impl or in its own file.

jart
jart requested changes Nov 18, 2023
View reviewed changes
Copy link
Owner

@jart jart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this! System calls are cosmo's bread and butter. It's very exciting to see contributions helping improve them.

libc/calls/cachestat.c Show resolved Hide resolved
libc/sysv/syscalls.sh Show resolved Hide resolved
test/libc/calls/cachestat_test.c Outdated Show resolved Hide resolved
@The-King-of-Toasters The-King-of-Toasters force-pushed the linux-6.6-updates branch 2 times, most recently from e66c919 to 2567220 Compare November 19, 2023 03:04
@The-King-of-Toasters
Copy link
Contributor Author

I tried adding cachestat to kPledgeStdio, but I kept getting ENOSYS errors. Might be worth following up yourself.

jart
jart approved these changes Nov 20, 2023
View reviewed changes
Copy link
Owner

@jart jart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

@jart jart merged commit cc5c531 into jart:master Nov 20, 2023
5 checks passed
@The-King-of-Toasters The-King-of-Toasters mentioned this pull request Jan 5, 2024
Closed
@The-King-of-Toasters The-King-of-Toasters deleted the linux-6.6-updates branch January 5, 2024 01:15
G4Vi pushed a commit to G4Vi/cosmopolitan that referenced this pull request Jan 19, 2024
@The-King-of-Toasters @G4Vi
Linux: Add cachestat, fchmodat2 syscalls (jart#958)
acce37b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jart jart jart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@The-King-of-Toasters @jart