Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metal] Some minor fixes and tweaks #933

Merged
merged 4 commits into from
Nov 14, 2023
Merged

[metal] Some minor fixes and tweaks #933

merged 4 commits into from
Nov 14, 2023

Conversation

tkchia
Copy link
Contributor

@tkchia tkchia commented Nov 5, 2023

No description provided.

@tkchia tkchia marked this pull request as ready for review November 6, 2023 21:58
tkchia added 2 commits November 6, 2023 22:04
Part of the memory occupied by the argv[] contents was
erroneously used for page tables & then later erroneously
freed.  The symptom was that argv[0] would show up as an
empty string ("").
Copy link
Owner

@jart jart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jart jart merged commit eea601f into jart:master Nov 14, 2023
5 checks passed
G4Vi pushed a commit to G4Vi/cosmopolitan that referenced this pull request Jan 19, 2024
* [metal] Ensure DF is clear when calling C from exception handler
* [metal] Mark some internal routines and declarations as `@internal`
* [metal] Fix crash under UEFI when command line string is NULL
* [metal] Fix argc & argv[] setting, & VM page freeing, for UEFI

Part of the memory occupied by the argv[] contents was
erroneously used for page tables & then later erroneously
freed.  The symptom was that argv[0] would show up as an
empty string ("").
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants