Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix strtod NaN handling / fix SIGSEGV in testlib/showerror #901

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Fix strtod NaN handling / fix SIGSEGV in testlib/showerror #901

merged 3 commits into from
Sep 27, 2023

Conversation

G4Vi
Copy link
Collaborator

@G4Vi G4Vi commented Sep 22, 2023

We could change the NAN_WORD0/ NAN_WORD1 macros instead. I chose to hardcode the constants to match the style of the infinity and other nan case.

On error in strtod_test.c tinyprint crashed without a NULL arg at the end being passed.

@G4Vi G4Vi mentioned this pull request Sep 26, 2023
Merged
jart
jart approved these changes Sep 27, 2023
View reviewed changes
Copy link
Owner

@jart jart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jart jart merged commit cc8c56e into jart:master Sep 27, 2023
5 checks passed
G4Vi added a commit to G4Vi/cosmopolitan that referenced this pull request Jan 19, 2024
@G4Vi
Fix strtod NaN handling / fix SIGSEGV in testlib/showerror (jart#901)
62b6cfa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jart jart jart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@G4Vi @jart