-
-
Notifications
You must be signed in to change notification settings - Fork 645
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
1 changed file
with
2 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8c2bf34
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a comment here #601 (comment) about the need/usage of
-pg
on the readme and other examples.There is any need to compile with profiling (
-pg
) ?8c2bf34
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also after you've recommended to look at cosmocc/cosmo++ here #601 (comment) I looked at it and found some typos there.
There is several repetitions of the prefix
/opt/cosmo
and also what probably is a typo/opt/cosmos
.For my tests I replaced all of the prefixes with a variable that can be overwritten in one place:
8c2bf34
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I asked/suggested here #601 (comment) to have
STATIC_STACK_SIZE(0xXXXX);
to be mentioned everywhere a cosmopolitan build is mentioned because it seem to be crucial to a successful build of third party applications with cosmopolitan like I discovered after several try and error attempts here #601 .8c2bf34
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/opt/cosmos
is not a typo. It's assumed that you'll use./configure --prefix=/opt/cosmos
when configuring open source projects. In that case,/opt/cosmos
becomes your own personal distro.-pg
if you want--ftrace
to support. Read https://justine.lol/ftrace/ and note that this has nearly zero overhead if you can use a flag like-mnop-mcount
which causes a NOP to be inserted in the prologue of functions.STATIC_STACK_SIZE(0xXXXX)
shouldn't be as necessary anymore.8c2bf34
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for reply !
And sorry for not know that the info about some aspects of cosmopolitan is already documented.
Cheers !
8c2bf34
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About the
STATIC_STACK_SIZE(0xXXXX)
I still think that it's relevant because as pointed here #601 (comment) when compiling several versions of Lua and trying to execute some tests for my surprise each version required a different value to pass the tests (using the latest cosmopolitan build withoutSTATIC_STACK_SIZE(0xXXXX)
they all segfault when trying to execute the tests see the source to reproduce here https://github.com/jart/cosmopolitan/files/9534950/am-lua-all.zip).