Skip to content

Commit

Permalink
EXPERIMENTAL: Remove help-sibling2 wrapper
Browse files Browse the repository at this point in the history
  • Loading branch information
janfaracik committed Sep 18, 2024
1 parent cc86227 commit 2b7c2a2
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 26 deletions.
38 changes: 18 additions & 20 deletions core/src/main/resources/lib/form/hetero-list.jelly
Original file line number Diff line number Diff line change
Expand Up @@ -81,33 +81,31 @@ THE SOFTWARE.
</st:documentation>
<d:taglib uri="local">
<d:tag name="body">
<div class="help-sibling2" style="width:100%">
<j:set var="help" value="${descriptor.helpFile}" />
<j:set var="disableHandle" value="${attrs.disableDragAndDrop or readOnlyMode}" />
<j:set var="help" value="${descriptor.helpFile}" />
<j:set var="disableHandle" value="${attrs.disableDragAndDrop or readOnlyMode}" />

<div class="repeated-chunk__header ${disableHandle ? 'repeated-chunk__header--TODO' : ''}">
<j:if test="${!disableHandle}">
<div class="dd-handle" />
</j:if>
<div class="repeated-chunk__header ${disableHandle ? 'repeated-chunk__header--TODO' : ''}">
<j:if test="${!disableHandle}">
<div class="dd-handle" />
</j:if>

${descriptor.displayName}
${descriptor.displayName}

<f:helpLink url="${help}"/>
<f:helpLink url="${help}"/>

<j:if test="${!readOnlyMode}">
<f:repeatableDeleteButton value="${attrs.deleteCaption}" />
</j:if>
</div>
<j:if test="${!readOnlyMode}">
<f:repeatableDeleteButton value="${attrs.deleteCaption}" />
</j:if>
</div>

<f:class-entry descriptor="${descriptor}" />
<f:class-entry descriptor="${descriptor}" />

<div class="notafoodwriter">
<j:if test="${help!=null}">
<f:helpArea />
</j:if>
<div class="notafoodwriter">
<j:if test="${help!=null}">
<f:helpArea />
</j:if>

<d:invokeBody/>
</div>
<d:invokeBody/>
</div>
</d:tag>
</d:taglib>
Expand Down
9 changes: 3 additions & 6 deletions war/src/main/scss/form/_reorderable-list.scss
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ $exit-animation: 0.2s;

.repeated-chunk {
position: relative;
display: flex;
flex-direction: column;
gap: 0.5rem;
background: var(--card-background);
border-radius: calc(var(--form-input-border-radius) / 2);
transition:
Expand Down Expand Up @@ -197,12 +200,6 @@ $exit-animation: 0.2s;
opacity: 0 !important;
}

.help-sibling2 {
display: flex;
flex-direction: column;
gap: 0.5rem;
}

.notafoodwriter2 {
padding: 0 $inset $inset;

Expand Down

0 comments on commit 2b7c2a2

Please sign in to comment.