Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter messages in sub and tap command #100

Merged
merged 19 commits into from
Aug 28, 2024
Merged

Filter messages in sub and tap command #100

merged 19 commits into from
Aug 28, 2024

Conversation

jandelgado
Copy link
Owner

@jandelgado jandelgado commented Aug 23, 2024

Add filtering option to sub and tap command

commands. Both commands can now optionally filter messages using a
filter-expression, which can be applied to the message meta-data (aka
properties) and the message body.
@coveralls
Copy link

coveralls commented Aug 23, 2024

Pull Request Test Coverage Report for Build 10596043610

Details

  • 95 of 112 (84.82%) changed or added relevant lines in 7 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.4%) to 88.991%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/rabtap/predicate_expr.go 29 31 93.55%
cmd/rabtap/compression.go 7 12 58.33%
cmd/rabtap/subscribe.go 26 36 72.22%
Files with Coverage Reduction New Missed Lines %
cmd/rabtap/signal.go 3 55.56%
Totals Coverage Status
Change from base Build 10479465883: -0.4%
Covered Lines: 2603
Relevant Lines: 2925

💛 - Coveralls

@jandelgado jandelgado force-pushed the filter_messages branch 2 times, most recently from a8688da to 9f04c09 Compare August 23, 2024 17:22
@jandelgado jandelgado marked this pull request as ready for review August 28, 2024 11:41
@jandelgado jandelgado merged commit 8219fa6 into master Aug 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants