Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix bugs #9

wants to merge 1 commit into from

Conversation

milten21
Copy link

This PR is focuses on fixing issues described in sefidgaran/signalr_client#60.

Changes introduced:

  1. Append serverUrl query parameters instead of replacing them
  2. Close network stream when closing events stream.
  3. Create SseClientException that was commented out in order to represent error coming from sse_channel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant