Updated print and os_log calls to modern OSLog class. #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update all print and OS_log calls to OSLog.
Update to OSLog
|
There are a few SwiftLint warnings. If you install SwiftLint locally, the warnings should show up in Xcode. |
macblazer
requested changes
Oct 21, 2024
Xcode has a setting that will help. Using the Xcode > Settings menu command, under the Text Editing tab, then the Editing tab, turn on the "Automatically trim trailing whitespace" and "Including whitespace-only lines" checkboxes. |
watkyn
requested changes
Oct 21, 2024
Co-authored-by: Kyle Hammond <[email protected]>
Just one more SwiftLint issue to resolve. |
Made data call non-optional to address swiftLint error Non-optional String -> Data Conversion.
Update NetworkAuthManager.swift
|
Everything looking good! One last thing is to update the CHANGELOG.md about the logging. After that we can get this merged in. |
watkyn
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced all print and os_log calls with OSLog class calls: https://developer.apple.com/documentation/os/oslog
This is to address Should use os_log instead of print function #112: #112