Connection should optionally use client credentials #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that handles the Upload sheet, including the new Client Credentials options. Refactored the actual upload networking code out into an UploadManager type.
…loyment target to macOS 11.
…Kit based UploadViewController.
…xtra "-> Void" syntax on a block of code.
watkyn
approved these changes
Dec 4, 2023
macblazer
deleted the
120-connection-should-optionally-use-client-credentials
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the minimum deployment target to macOS 11 in order to use SwiftUI with decent capabilities.
The Upload sheet is now written in SwiftUI, and the client credentials option has been added. The sheet user-entry validation code has been simplified and made more robust. The user now receives confirmation of a successful upload instead of the sheet simply disappearing. If there are any problems with the upload the sheet is left open and displays an inline warning message.
The UX of requiring the connection to be verified before performing the upload has been improved. There are now simply two buttons in the bottom-right of the view. The Cancel button is always present. The other button is first titled "Check Connection", and then once the connection info has been verified the button changes title to "Upload". Also, if the user changes any connection related info after a successful "Check Connection" the button changes back and must go through the connection verification again.
Fixes #120