Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Log Collection and Execution Order #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pirkla
Copy link

@pirkla pirkla commented May 4, 2020

Change order of secondary script to only stop the daemon after the script has finished.
Previously the daemon was unloaded prior to removing the daemon's plist and collecting the logs which stopped script execution prematurely.

#1

pirkla added 3 commits May 4, 2020 16:07
Changed execution order to fix daemon stopping before the script was finished which stopped execution of the script
Updated comment on line 38 to reflect correct run interval time
Remove additional unload I missed like a dummy
@samuel-harvey
Copy link

samuel-harvey commented May 11, 2020

Hey! I'm testing this now. Can you confirm that it is able to remove admin rights? I'm getting the admin rights elevation but after my timer goes off the user is still admin.

Thanks for your work! :) 👍 edit: i'm activating the policy as the user via self-service / also could I be having an issue due to permissions/slack of PPPC config?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants