Make some minor tweaks to mysqldump_to_csv.py
#18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngie-eign
force-pushed
the
minor-tweaks
branch
from
739810d to
e27261f
Compare
* Use `.startswith(..)` in place of the unrolled versions of the equivalent functionality. * Use `if foo:` and `if not foo:` instead of `if len(foo) != 0:` and `if len(foo) == 0:`. The former set of patterns is more performant and it protects against `foo` potentially not being an iterable object, or an object that doesn't implement `.__len__(..)`. * Change the mode of the script to 0755 so it's executable out of the box. Signed-of-by: Enji Cooper <[email protected]>
ngie-eign
force-pushed
the
minor-tweaks
branch
from
e27261f to
f9990c8
Compare
This makes things more consistent, using an upstream stylization tool. Ref: https://github.com/psf/black
|
@jamesmishra: ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.startswith(..)in place of the unrolled versions of theequivalent functionality.
if foo:andif not foo:instead ofif len(foo) != 0:and
if len(foo) == 0:. The former set of patterns is moreperformant and it protects against
foopotentially not beingan iterable object, or an object that doesn't implement
.__len__(..).the box.
Signed-of-by: Enji Cooper [email protected]