Fix difference between two date times with asFloat param #267
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The difference between two date times had wrong test case which was hiding the actual issue.
The documentation for diff function mentioned:
but the asFloat default value was true
and in the inner function the logic was wrong
return asFloat ? _asFloor(diff) : diff;
Along with that the test case has wrong assumption, because of which it passed the test.
Issue Reference
Fixes #
Types of changes
Screenshots
If applicable, add screenshots to help explain your problem.
Checklist
./bin
folderAdditional Information