fixes: #362 Locale problem with JsonbNumberFormat #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzygielo
reviewed
Oct 20, 2024
| @@ -20,6 +20,7 @@ | |||
| import java.lang.annotation.Retention; | |||
| import java.lang.annotation.RetentionPolicy; | |||
| import java.lang.annotation.Target; | |||
| import java.util.Locale; | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
njr-11
requested changes
Oct 21, 2024
| @@ -36,6 +37,11 @@ | |||
| * <li> package </li> | |||
| * </ul> | |||
| * | |||
| * <p>Note that even when specifying a pattern format your JSON is depending on the Locale of the JVM you run on. | |||
There was a problem hiding this comment.
This sentence is difficult to understand without punctuation to identify which of the different parts go together and which don't. Here is one suggestion to clarify it while leaving it mostly as written,
Suggested change
| * <p>Note that even when specifying a pattern format your JSON is depending on the Locale of the JVM you run on. | |
| * <p>Note that even when specifying a pattern, the format of the JSON value depends on the Locale of the JVM by default. |
There was a problem hiding this comment.
txs for the review and suggestion!
|
will update, txs for the feedback! |
improvements in wording, copyright updated and unnecessary import removed.
njr-11
approved these changes
Oct 29, 2024
Verdent
approved these changes
Nov 13, 2024
mkarg
approved these changes
Dec 23, 2024
|
@jakartaee/ee4j-jsonb-project-leads This PR was approved by two committers weeks many weeks ago, so I wonder why not merging it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.