[refactor][storage][badger]Refactored the prefilling of cache to reader #6575
+118
−122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manik2708 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6575 +/- ##
=======================================
Coverage 96.23% 96.24%
=======================================
Files 373 373
Lines 21406 21404 -2
=======================================
Hits 20600 20600
+ Misses 614 612 -2
Partials 192 192
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Manik2708 <[email protected]>
yurishkuro
reviewed
Jan 20, 2025
Comment on lines
+667
to
+676
| if _, found := r.cache.operations[service]; !found { | ||
| r.cache.operations[service] = make(map[string]uint64) | ||
| } | ||
|
|
||
| if v, found := r.cache.operations[service][operationName]; found { | ||
| if v > keyTTL { | ||
| continue | ||
| } | ||
| } | ||
| r.cache.operations[service][operationName] = keyTTL |
There was a problem hiding this comment.
you now went the other way - reader knows too much about the cache. There should be a clear API boundary between reader and cache, e.g. all the reader should be doing here is something like cache.add(service, operation). Just because the cache is in the same package doesn't mean the reader should be accessing its private fields like that.
|
please provide better description of the changes in the PR description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Comment: #6376 (comment)
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test