[api_v3][query] Change api_v3 grpc handler to use query service v2 #6452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
mahadzaryab1
commented
Dec 31, 2024
mahadzaryab1
commented
Dec 31, 2024
yurishkuro
reviewed
Dec 31, 2024
yurishkuro
reviewed
Dec 31, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6452 +/- ##
=======================================
Coverage 96.26% 96.27%
=======================================
Files 370 371 +1
Lines 21144 21195 +51
=======================================
+ Hits 20355 20406 +51
Misses 604 604
Partials 185 185
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
yurishkuro
reviewed
Jan 1, 2025
yurishkuro
reviewed
Jan 1, 2025
Signed-off-by: Mahad Zaryab <[email protected]>
yurishkuro
reviewed
Jan 1, 2025
@yurishkuro yep - I need to fix the tests. Will do that now. |
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
mahadzaryab1
changed the title
mahadzaryab1
commented
Jan 1, 2025
cmd/query/app/flags.go
Outdated
| return opts | ||
| } | ||
|
|
||
| func initializeV2ArchiveStorage( |
There was a problem hiding this comment.
@yurishkuro we're repeating this logic two times at the moment (here and in the query server). Should we move this into a common helper somewhere?
There was a problem hiding this comment.
ok to leave for now. We haven't finished archive factory PR, but the idea was that in the v2 extension we won't be using v1adapter but get v2 reader/writer directly from storage extension.
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
mahadzaryab1
changed the title
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
yurishkuro
changed the title
yurishkuro
approved these changes
Jan 1, 2025
2 tasks
Manik2708
pushed a commit
to Manik2708/jaeger
that referenced
this pull request
Jan 2, 2025
…aegertracing#6452) ## Which problem is this PR solving? - Towards jaegertracing#6337 ## Description of the changes - This PR migrates the v3_api GRPC handler to use the new v2 query service. ## How was this change tested? - CI ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Mahad Zaryab <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test