Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make api_v3 proto accessible from other packages #6421

Merged
merged 3 commits into from
Dec 27, 2024

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Dec 26, 2024

Which problem is this PR solving?

Description of the changes

  • Move api_v3 to internal/proto/api_v3 to be accessible from all of the code base

How was this change tested?

  • CI

@yurishkuro yurishkuro requested a review from a team as a code owner December 26, 2024 23:53
@yurishkuro yurishkuro added the changelog:skip Trivial change that does not require an entry in CHANGELOG label Dec 26, 2024
@yurishkuro yurishkuro enabled auto-merge (squash) December 26, 2024 23:58
Signed-off-by: Yuri Shkuro <[email protected]>
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.27%. Comparing base (8c2a82b) to head (7fab7a0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6421   +/-   ##
=======================================
  Coverage   96.27%   96.27%           
=======================================
  Files         368      368           
  Lines       21008    21008           
=======================================
  Hits        20225    20225           
  Misses        599      599           
  Partials      184      184           
Flag Coverage Δ
badger_v1 10.55% <ø> (ø)
badger_v2 3.03% <ø> (ø)
cassandra-4.x-v1-manual 16.43% <ø> (ø)
cassandra-4.x-v2-auto 2.96% <ø> (ø)
cassandra-4.x-v2-manual 2.96% <ø> (ø)
cassandra-5.x-v1-manual 16.43% <ø> (ø)
cassandra-5.x-v2-auto 2.96% <ø> (ø)
cassandra-5.x-v2-manual 2.96% <ø> (ø)
elasticsearch-6.x-v1 20.16% <ø> (ø)
elasticsearch-7.x-v1 20.23% <ø> (ø)
elasticsearch-8.x-v1 20.39% <ø> (ø)
elasticsearch-8.x-v2 3.05% <ø> (ø)
grpc_v1 12.21% <ø> (+<0.01%) ⬆️
grpc_v2 9.31% <ø> (+<0.01%) ⬆️
kafka-2.x-v1 10.39% <ø> (ø)
kafka-2.x-v2 3.06% <ø> (ø)
kafka-3.x-v1 10.39% <ø> (ø)
kafka-3.x-v2 3.06% <ø> (ø)
memory_v2 3.06% <ø> (ø)
opensearch-1.x-v1 20.28% <ø> (-0.01%) ⬇️
opensearch-2.x-v1 20.29% <ø> (+<0.01%) ⬆️
opensearch-2.x-v2 3.06% <ø> (+<0.01%) ⬆️
tailsampling-processor 0.56% <ø> (ø)
unittests 95.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit 8e8f72e into jaegertracing:main Dec 27, 2024
56 checks passed
@yurishkuro yurishkuro deleted the move-apiv3 branch December 27, 2024 00:13
Manik2708 pushed a commit to Manik2708/jaeger that referenced this pull request Jan 5, 2025
## Which problem is this PR solving?
- Part of jaegertracing#6422
- We cannot use api_v3 proto types outside of query service (namely from
e2e v2 integration tests) because they are in the `internal` package

## Description of the changes
- Move api_v3 to `internal/proto/api_v3` to be accessible from all of
the code base

## How was this change tested?
- CI

Signed-off-by: Yuri Shkuro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:skip Trivial change that does not require an entry in CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants