-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add time window for GetTrace of anonymizer #6368
Feat: Add time window for GetTrace of anonymizer #6368
Conversation
Signed-off-by: Zhang Xin <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6368 +/- ##
=======================================
Coverage 96.16% 96.16%
=======================================
Files 360 360
Lines 20484 20496 +12
=======================================
+ Hits 19698 19710 +12
Misses 601 601
Partials 185 185
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cmd/anonymizer/app/flags.go
Outdated
command.Flags().Int64Var( | ||
&o.StartTime, | ||
startTime, | ||
-1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not 0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, 0 makes things easier
cmd/anonymizer/main.go
Outdated
@@ -53,7 +54,9 @@ func main() { | |||
logger.Fatal("error while creating query object", zap.Error(err)) | |||
} | |||
|
|||
spans, err := query.QueryTrace(options.TraceID) | |||
startTime := time.Unix(0, options.StartTime) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this check for sentinel value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed default value as 0, so no need to check then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still need to check, time 0 is not the same as epoch 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Signed-off-by: Zhang Xin <[email protected]>
Signed-off-by: Zhang Xin <[email protected]>
2b2e461
to
f7d3789
Compare
Signed-off-by: Yuri Shkuro <[email protected]>
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:npm run lint
andnpm run test