Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Rename factoryadapter to v1adapter #6365

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

  • factoryadapter was inaccurate name since it provides more than a factory

Description of the changes

  • Rename factoryadapter package to v1adapter

How was this change tested?

  • CI

@yurishkuro yurishkuro requested a review from a team as a code owner December 15, 2024 19:22
@yurishkuro yurishkuro requested a review from jkowall December 15, 2024 19:22
@yurishkuro yurishkuro added the changelog:skip Trivial change that does not require an entry in CHANGELOG label Dec 15, 2024
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.13%. Comparing base (d6456fb) to head (9de564b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6365      +/-   ##
==========================================
- Coverage   96.14%   96.13%   -0.01%     
==========================================
  Files         360      360              
  Lines       20479    20479              
==========================================
- Hits        19689    19687       -2     
- Misses        603      605       +2     
  Partials      187      187              
Flag Coverage Δ
badger_v1 8.96% <0.00%> (ø)
badger_v2 1.63% <0.00%> (ø)
cassandra-4.x-v1-manual 14.93% <0.00%> (ø)
cassandra-4.x-v2-auto 1.57% <0.00%> (ø)
cassandra-4.x-v2-manual 1.57% <0.00%> (ø)
cassandra-5.x-v1-manual 14.93% <0.00%> (ø)
cassandra-5.x-v2-auto 1.57% <0.00%> (ø)
cassandra-5.x-v2-manual 1.57% <0.00%> (ø)
elasticsearch-6.x-v1 18.62% <0.00%> (ø)
elasticsearch-7.x-v1 18.70% <0.00%> (ø)
elasticsearch-8.x-v1 18.85% <0.00%> (-0.01%) ⬇️
elasticsearch-8.x-v2 1.63% <0.00%> (ø)
grpc_v1 10.59% <0.00%> (ø)
grpc_v2 7.95% <0.00%> (+<0.01%) ⬆️
kafka-v1 9.28% <0.00%> (ø)
kafka-v2 1.63% <0.00%> (ø)
memory_v2 1.63% <0.00%> (ø)
opensearch-1.x-v1 18.75% <0.00%> (ø)
opensearch-2.x-v1 18.75% <0.00%> (ø)
opensearch-2.x-v2 1.63% <0.00%> (ø)
tailsampling-processor 0.45% <0.00%> (ø)
unittests 95.01% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Yuri Shkuro <[email protected]>
"github.com/jaegertracing/jaeger/storage_v2/tracestore"
"github.com/jaegertracing/jaeger/storage_v2/v1adapter"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yurishkuro is there any reason that we can't just call it adapter?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adapter is too generic of a term

@yurishkuro yurishkuro merged commit dad636b into jaegertracing:main Dec 16, 2024
54 checks passed
@yurishkuro yurishkuro deleted the v1adapter branch December 16, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:skip Trivial change that does not require an entry in CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants