-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor] Rename factoryadapter to v1adapter #6365
Conversation
Signed-off-by: Yuri Shkuro <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6365 +/- ##
==========================================
- Coverage 96.14% 96.13% -0.01%
==========================================
Files 360 360
Lines 20479 20479
==========================================
- Hits 19689 19687 -2
- Misses 603 605 +2
Partials 187 187
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Yuri Shkuro <[email protected]>
"github.com/jaegertracing/jaeger/storage_v2/tracestore" | ||
"github.com/jaegertracing/jaeger/storage_v2/v1adapter" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yurishkuro is there any reason that we can't just call it adapter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adapter is too generic of a term
Which problem is this PR solving?
factoryadapter
was inaccurate name since it provides more than a factoryDescription of the changes
factoryadapter
package tov1adapter
How was this change tested?