Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jaeger][v2] implement span links adjuster to operate on otlp data model #6354

Merged
merged 4 commits into from
Dec 13, 2024

Conversation

mahadzaryab1
Copy link
Collaborator

Which problem is this PR solving?

Description of the changes

  • This PR implements the SpanReferences adjuster to operate on the OTLP data model. In the OTLP model, references are dubbed as links so the adjuster was renamed to SpanLinks

How was this change tested?

  • Added unit tests

Checklist

@mahadzaryab1 mahadzaryab1 requested a review from a team as a code owner December 13, 2024 02:24
@mahadzaryab1 mahadzaryab1 changed the title [jaeger][v2] implement links (span references) Adjuster [jaeger][v2] implement links (span references) adjuster to operate on otlp data model Dec 13, 2024
@dosubot dosubot bot added the v2 label Dec 13, 2024
@mahadzaryab1 mahadzaryab1 changed the title [jaeger][v2] implement links (span references) adjuster to operate on otlp data model [jaeger][v2] implement span links adjuster to operate on otlp data model Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.08%. Comparing base (737be78) to head (1f395d7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6354      +/-   ##
==========================================
+ Coverage   96.07%   96.08%   +0.01%     
==========================================
  Files         358      359       +1     
  Lines       20477    20504      +27     
==========================================
+ Hits        19673    19702      +29     
+ Misses        613      611       -2     
  Partials      191      191              
Flag Coverage Δ
badger_v1 8.84% <ø> (ø)
badger_v2 1.60% <ø> (ø)
cassandra-4.x-v1-manual 14.74% <ø> (ø)
cassandra-4.x-v2-auto 1.55% <ø> (ø)
cassandra-4.x-v2-manual 1.55% <ø> (ø)
cassandra-5.x-v1-manual 14.74% <ø> (ø)
cassandra-5.x-v2-auto 1.55% <ø> (ø)
cassandra-5.x-v2-manual 1.55% <ø> (ø)
elasticsearch-6.x-v1 18.37% <ø> (ø)
elasticsearch-7.x-v1 18.44% <ø> (-0.01%) ⬇️
elasticsearch-8.x-v1 18.61% <ø> (+<0.01%) ⬆️
elasticsearch-8.x-v2 1.60% <ø> (ø)
grpc_v1 10.33% <ø> (-0.01%) ⬇️
grpc_v2 7.81% <ø> (ø)
kafka-v1 9.17% <ø> (ø)
kafka-v2 1.60% <ø> (ø)
memory_v2 1.60% <ø> (-0.01%) ⬇️
opensearch-1.x-v1 18.50% <ø> (+<0.01%) ⬆️
opensearch-2.x-v1 18.49% <ø> (-0.01%) ⬇️
opensearch-2.x-v2 1.60% <ø> (ø)
tailsampling-processor 0.45% <ø> (ø)
unittests 94.97% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Mahad Zaryab <[email protected]>
@mahadzaryab1 mahadzaryab1 enabled auto-merge (squash) December 13, 2024 02:46
@mahadzaryab1 mahadzaryab1 merged commit e98f7f5 into jaegertracing:main Dec 13, 2024
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants