-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[remote-storage] Use OTEL helper instead of tlscfg #6351
[remote-storage] Use OTEL helper instead of tlscfg #6351
Conversation
Signed-off-by: chahatsagarmain <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6351 +/- ##
=======================================
Coverage 96.05% 96.05%
=======================================
Files 358 358
Lines 20484 20477 -7
=======================================
- Hits 19676 19670 -6
+ Misses 617 615 -2
- Partials 191 192 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cmd/remote-storage/app/flags.go
Outdated
GRPCHostPort string | ||
// TLSGRPC configures secure transport | ||
TLSGRPC tlscfg.Options | ||
GRPCCFG *configgrpc.ServerConfig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GRPCCFG *configgrpc.ServerConfig | |
configgrpc.ServerConfig |
Signed-off-by: chahatsagarmain <[email protected]>
cmd/remote-storage/app/flags.go
Outdated
GRPCHostPort string | ||
// TLSGRPC configures secure transport | ||
TLSGRPC tlscfg.Options | ||
*configgrpc.ServerConfig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*configgrpc.ServerConfig | |
configgrpc.ServerConfig |
Signed-off-by: chahatsagarmain <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Thanks! |
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test