Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[remote-storage] Use OTEL helper instead of tlscfg #6351

Merged
merged 5 commits into from
Dec 13, 2024

Conversation

chahatsagarmain
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

How was this change tested?

Checklist

Signed-off-by: chahatsagarmain <[email protected]>
@chahatsagarmain chahatsagarmain requested a review from a team as a code owner December 12, 2024 21:06
@dosubot dosubot bot added the area/storage label Dec 12, 2024
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.05%. Comparing base (0833839) to head (c269f7f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6351   +/-   ##
=======================================
  Coverage   96.05%   96.05%           
=======================================
  Files         358      358           
  Lines       20484    20477    -7     
=======================================
- Hits        19676    19670    -6     
+ Misses        617      615    -2     
- Partials      191      192    +1     
Flag Coverage Δ
badger_v1 8.84% <0.00%> (+<0.01%) ⬆️
badger_v2 1.60% <0.00%> (+<0.01%) ⬆️
cassandra-4.x-v1-manual 14.74% <0.00%> (+<0.01%) ⬆️
cassandra-4.x-v2-auto 1.55% <0.00%> (+<0.01%) ⬆️
cassandra-4.x-v2-manual 1.55% <0.00%> (+<0.01%) ⬆️
cassandra-5.x-v1-manual 14.74% <0.00%> (+<0.01%) ⬆️
cassandra-5.x-v2-auto 1.55% <0.00%> (+<0.01%) ⬆️
cassandra-5.x-v2-manual 1.55% <0.00%> (+<0.01%) ⬆️
elasticsearch-6.x-v1 18.37% <0.00%> (+0.02%) ⬆️
elasticsearch-7.x-v1 18.44% <0.00%> (+<0.01%) ⬆️
elasticsearch-8.x-v1 18.60% <0.00%> (+0.01%) ⬆️
elasticsearch-8.x-v2 1.60% <0.00%> (+<0.01%) ⬆️
grpc_v1 10.34% <66.66%> (+0.01%) ⬆️
grpc_v2 7.81% <66.66%> (+0.01%) ⬆️
kafka-v1 9.17% <0.00%> (+<0.01%) ⬆️
kafka-v2 1.60% <0.00%> (+0.01%) ⬆️
memory_v2 1.60% <0.00%> (+<0.01%) ⬆️
opensearch-1.x-v1 18.50% <0.00%> (+0.01%) ⬆️
opensearch-2.x-v1 18.49% <0.00%> (+<0.01%) ⬆️
opensearch-2.x-v2 1.60% <0.00%> (+<0.01%) ⬆️
tailsampling-processor 0.45% <0.00%> (+<0.01%) ⬆️
unittests 94.94% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

GRPCHostPort string
// TLSGRPC configures secure transport
TLSGRPC tlscfg.Options
GRPCCFG *configgrpc.ServerConfig
Copy link
Member

@yurishkuro yurishkuro Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
GRPCCFG *configgrpc.ServerConfig
configgrpc.ServerConfig

Signed-off-by: chahatsagarmain <[email protected]>
GRPCHostPort string
// TLSGRPC configures secure transport
TLSGRPC tlscfg.Options
*configgrpc.ServerConfig
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*configgrpc.ServerConfig
configgrpc.ServerConfig

Signed-off-by: chahatsagarmain <[email protected]>
@yurishkuro yurishkuro enabled auto-merge (squash) December 13, 2024 00:38
@yurishkuro yurishkuro merged commit 737be78 into jaegertracing:main Dec 13, 2024
54 checks passed
@yurishkuro
Copy link
Member

Thanks!

@chahatsagarmain chahatsagarmain deleted the remote-storate-tlscfg branch December 13, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants