Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2][query] Add interface for adjuster to operate on OTLP data format #6346

Merged
merged 5 commits into from
Dec 12, 2024

Conversation

mahadzaryab1
Copy link
Collaborator

Which problem is this PR solving?

Description of the changes

  • This PR adds an interface for Adjuster to operate on the OTLP model format so that it can be used by the v2 query service. The v1 interface/implementation can be found in model/adjuster.
  • In the following PRs, we'll implement all the standard adjusters in model/adjuster to implement the new interface.

How was this change tested?

  • Unit tests

Checklist

@mahadzaryab1 mahadzaryab1 requested a review from a team as a code owner December 12, 2024 03:42
@mahadzaryab1 mahadzaryab1 requested a review from jkowall December 12, 2024 03:42
Signed-off-by: Mahad Zaryab <[email protected]>
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.05%. Comparing base (8696541) to head (8f60bd4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6346      +/-   ##
==========================================
+ Coverage   96.02%   96.05%   +0.02%     
==========================================
  Files         357      358       +1     
  Lines       20467    20484      +17     
==========================================
+ Hits        19654    19676      +22     
+ Misses        621      617       -4     
+ Partials      192      191       -1     
Flag Coverage Δ
badger_v1 8.76% <ø> (ø)
badger_v2 1.60% <ø> (ø)
cassandra-4.x-v1-manual 14.73% <ø> (ø)
cassandra-4.x-v2-auto 1.55% <ø> (ø)
cassandra-4.x-v2-manual 1.55% <ø> (ø)
cassandra-5.x-v1-manual 14.73% <ø> (ø)
cassandra-5.x-v2-auto 1.55% <ø> (ø)
cassandra-5.x-v2-manual 1.55% <ø> (ø)
elasticsearch-6.x-v1 18.35% <ø> (ø)
elasticsearch-7.x-v1 18.44% <ø> (ø)
elasticsearch-8.x-v1 18.59% <ø> (-0.01%) ⬇️
elasticsearch-8.x-v2 1.59% <ø> (-0.01%) ⬇️
grpc_v1 10.24% <ø> (ø)
grpc_v2 7.79% <ø> (ø)
kafka-v1 9.16% <ø> (ø)
kafka-v2 1.60% <ø> (ø)
memory_v2 1.59% <ø> (-0.01%) ⬇️
opensearch-1.x-v1 18.48% <ø> (ø)
opensearch-2.x-v1 18.48% <ø> (ø)
opensearch-2.x-v2 1.60% <ø> (+<0.01%) ⬆️
tailsampling-processor 0.45% <ø> (ø)
unittests 94.96% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit d69dad5 into jaegertracing:main Dec 12, 2024
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants