Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pring EOL notice from v1 binaries #6322

Merged
merged 2 commits into from
Dec 7, 2024
Merged

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Dec 7, 2024

Which problem is this PR solving?

Description of the changes

  • Print EOL notice from core v1 binaries

How was this change tested?

$ go run ./cmd/all-in-one
2024/12/07 13:02:54 maxprocs: Leaving GOMAXPROCS=12: CPU quota undefined

*******************************************************************************

🛑  WARNING: End-of-life Notice for Jaeger v1

You are currently running a v1 version of Jaeger, which is deprecated and will
reach end-of-life on December 31st, 2025. This means there will be no further
development, bug fixes, or security patches for v1 after this date.

We strongly recommend migrating to Jaeger v2 for continued support and access
to new features.

For detailed migration instructions, please refer to the official Jaeger
documentation:  https://www.jaegertracing.io/docs/latest/migration/

Tracking issue: https://github.com/jaegertracing/jaeger/issues/6321

🛑  WARNING: End-of-life Notice for Jaeger v1

*******************************************************************************

2024/12/07 13:02:54 application version: git-commit=, git-version=, build-date=
{"level":"info","ts":1733594574.315758,"caller":"flags/service.go:123","msg":"Mounting metrics handler on admin server","route":"/metrics"}

@yurishkuro yurishkuro requested a review from a team as a code owner December 7, 2024 18:05
@yurishkuro yurishkuro requested a review from albertteoh December 7, 2024 18:05
Signed-off-by: Yuri Shkuro <[email protected]>
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 96.11%. Comparing base (65cff3c) to head (6f725fd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/internal/flags/service.go 0.00% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6322      +/-   ##
==========================================
- Coverage   96.25%   96.11%   -0.15%     
==========================================
  Files         356      356              
  Lines       20454    20476      +22     
==========================================
- Hits        19689    19681       -8     
- Misses        579      607      +28     
- Partials      186      188       +2     
Flag Coverage Δ
badger_v1 8.83% <ø> (ø)
badger_v2 1.62% <ø> (ø)
cassandra-4.x-v1-manual 14.73% <ø> (ø)
cassandra-4.x-v2-auto 1.56% <ø> (ø)
cassandra-4.x-v2-manual 1.56% <ø> (ø)
cassandra-5.x-v1-manual 14.73% <ø> (ø)
cassandra-5.x-v2-auto 1.56% <ø> (ø)
cassandra-5.x-v2-manual 1.56% <ø> (ø)
elasticsearch-6.x-v1 18.47% <ø> (ø)
elasticsearch-7.x-v1 18.55% <ø> (ø)
elasticsearch-8.x-v1 18.70% <ø> (-0.01%) ⬇️
elasticsearch-8.x-v2 1.61% <ø> (ø)
grpc_v1 10.29% <ø> (+<0.01%) ⬆️
grpc_v2 7.85% <ø> (ø)
kafka-v1 8.52% <ø> (ø)
kafka-v2 1.62% <ø> (ø)
memory_v2 1.62% <ø> (+<0.01%) ⬆️
opensearch-1.x-v1 18.60% <ø> (ø)
opensearch-2.x-v1 18.59% <ø> (ø)
opensearch-2.x-v2 1.61% <ø> (-0.01%) ⬇️
tailsampling-processor 0.45% <ø> (ø)
unittests 95.02% <0.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mahadzaryab1 mahadzaryab1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - there's just a typo in the title (Pring -> Print)

Comment on lines +58 to +59
For detailed migration instructions, please refer to the official Jaeger
documentation: https://www.jaegertracing.io/docs/latest/migration/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For detailed migration instructions, please refer to the official Jaeger
documentation: https://www.jaegertracing.io/docs/latest/migration/
For detailed migration instructions, please refer to the official Jaeger
documentation: https://www.jaegertracing.io/docs/latest/migration/

@yurishkuro yurishkuro merged commit 56c09d3 into jaegertracing:main Dec 7, 2024
53 of 55 checks passed
@yurishkuro yurishkuro deleted the v1-eol branch December 7, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants