-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pring EOL notice from v1 binaries #6322
Conversation
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6322 +/- ##
==========================================
- Coverage 96.25% 96.11% -0.15%
==========================================
Files 356 356
Lines 20454 20476 +22
==========================================
- Hits 19689 19681 -8
- Misses 579 607 +28
- Partials 186 188 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - there's just a typo in the title (Pring
-> Print
)
For detailed migration instructions, please refer to the official Jaeger | ||
documentation: https://www.jaegertracing.io/docs/latest/migration/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For detailed migration instructions, please refer to the official Jaeger | |
documentation: https://www.jaegertracing.io/docs/latest/migration/ | |
For detailed migration instructions, please refer to the official Jaeger | |
documentation: https://www.jaegertracing.io/docs/latest/migration/ |
Which problem is this PR solving?
Description of the changes
How was this change tested?