Compatibility updates for v2 in README #6316
Open
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonah Kowall <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6316 +/- ##
=======================================
Coverage 96.22% 96.22%
=======================================
Files 356 356
Lines 20454 20454
=======================================
Hits 19681 19681
Misses 585 585
Partials 188 188
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
reviewed
Dec 8, 2024
| @@ -67,7 +67,7 @@ For example, any given Jaeger installation at Uber is typically processing sever | |||
|
|
|||
| ### Relationship with OpenTelemetry | |||
There was a problem hiding this comment.
Hm, I recently removed this section altogether, moved it to the documentation.
https://www.jaegertracing.io/docs/next-release-v2/#relationship-with-opentelemetry
yurishkuro
reviewed
Dec 8, 2024
| @@ -124,19 +124,19 @@ of routing the traffic from Zipkin libraries to the Jaeger backend. | |||
|
|
|||
| ## Version Compatibility Guarantees | |||
|
|
|||
| Occasionally, CLI flags can be deprecated due to, for example, usability improvements or new functionality. | |||
| Since Jaeger uses many components from the [OpenTelemetry Collector](https://github.com/open-telemetry/opentelemetry-collector/) we try to maintain configuration compatibility between Jaeger releases. Occasionally, configuration elements in Jaeger (or in Jaeger v1 CLI flags) can be deprecated due to usability improvements, new functionality, or changes in our dependencies. | |||
There was a problem hiding this comment.
I think "configuration option" used in L129 sounds better than "element", perhaps converge to that one for consistency?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Addresses part of jaegertracing/documentation#117
Description of the changes
Update text to match Jaeger v2
How was this change tested?
Not tested
Checklist