Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Return nil from storage factories when there is an error in creating span reader #6293

Merged
merged 6 commits into from
Dec 3, 2024

Conversation

mahadzaryab1
Copy link
Collaborator

Which problem is this PR solving?

Description of the changes

  • This PR makes a minor fix to return nil in the cassandra and es storage factories when there is an error creating the storage factory before decorating it

How was this change tested?

  • CI

Checklist

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.24%. Comparing base (57a19af) to head (846db53).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6293      +/-   ##
==========================================
+ Coverage   96.22%   96.24%   +0.01%     
==========================================
  Files         356      356              
  Lines       20432    20432              
==========================================
+ Hits        19661    19665       +4     
+ Misses        583      581       -2     
+ Partials      188      186       -2     
Flag Coverage Δ
badger_v1 8.90% <0.00%> (ø)
badger_v2 1.62% <0.00%> (ø)
cassandra-4.x-v1-manual 14.84% <0.00%> (ø)
cassandra-4.x-v2-auto 1.56% <0.00%> (ø)
cassandra-4.x-v2-manual 1.56% <0.00%> (ø)
cassandra-5.x-v1-manual 14.84% <0.00%> (ø)
cassandra-5.x-v2-auto 1.56% <0.00%> (ø)
cassandra-5.x-v2-manual 1.56% <0.00%> (ø)
elasticsearch-6.x-v1 18.60% <0.00%> (ø)
elasticsearch-7.x-v1 18.68% <0.00%> (+<0.01%) ⬆️
elasticsearch-8.x-v1 18.84% <0.00%> (+<0.01%) ⬆️
elasticsearch-8.x-v2 1.61% <0.00%> (ø)
grpc_v1 10.37% <0.00%> (ø)
grpc_v2 7.86% <0.00%> (-0.01%) ⬇️
kafka-v1 8.58% <0.00%> (ø)
kafka-v2 1.62% <0.00%> (ø)
memory_v2 1.62% <0.00%> (ø)
opensearch-1.x-v1 18.73% <0.00%> (+<0.01%) ⬆️
opensearch-2.x-v1 18.72% <0.00%> (ø)
opensearch-2.x-v2 1.61% <0.00%> (ø)
tailsampling-processor 0.45% <0.00%> (ø)
unittests 95.15% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit cc16ce8 into jaegertracing:main Dec 3, 2024
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants