Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metrics][storage] Move metrics reader decorator to metrics storage factory #6287

Merged
merged 10 commits into from
Dec 1, 2024

Merge branch 'main' into metrics-store-metrics

4842837
Select commit
Loading
Failed to load commit list.
Merged

[metrics][storage] Move metrics reader decorator to metrics storage factory #6287

Merge branch 'main' into metrics-store-metrics
4842837
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 1, 2024 in 1s

96.21% (target 95.00%)

View this Pull Request on Codecov

96.21% (target 95.00%)

Details

Codecov Report

Attention: Patch coverage is 91.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 96.21%. Comparing base (beef883) to head (4842837).

Files with missing lines Patch % Lines
plugin/metrics/prometheus/factory.go 70.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6287      +/-   ##
==========================================
+ Coverage   96.18%   96.21%   +0.02%     
==========================================
  Files         356      356              
  Lines       20416    20432      +16     
==========================================
+ Hits        19637    19658      +21     
+ Misses        589      585       -4     
+ Partials      190      189       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.