[V3/API] Add time window for GetTrace http_gateway #6248
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rim99
force-pushed
the
http-api-time-window-trace-get
branch
from
851c3ad to
d31c84e
Compare
4 tasks
rim99
force-pushed
the
http-api-time-window-trace-get
branch
from
d31c84e to
bd100ec
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6248 +/- ##
=======================================
Coverage 96.11% 96.12%
=======================================
Files 360 360
Lines 20485 20500 +15
=======================================
+ Hits 19690 19705 +15
Misses 607 607
Partials 188 188
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rim99
changed the title
yurishkuro
reviewed
Dec 16, 2024
Comment on lines
+98
to
+99
| expectedQuery spanstore.GetTraceParameters | ||
| params map[string]string |
There was a problem hiding this comment.
if params are the input please move them above the expected values, in both struct declaration and in the initialization below.
| } | ||
|
|
||
| func TestHTTPGatewayGetTraceInternalErrors(t *testing.T) { | ||
| gw := setupHTTPGatewayNoServer(t, "") | ||
| // error from span reader | ||
| const simErr = "simulated error" | ||
| gw.reader. | ||
| On("GetTrace", matchContext, matchGetTraceParameters). | ||
| Return(nil, errors.New(simErr)).Once() |
There was a problem hiding this comment.
can use assert.AnError instead of simErr
|
Use new PR: #6372 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test