Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v2][storage] Implement read path for v2 storage interface #6170
[v2][storage] Implement read path for v2 storage interface #6170
Changes from all commits
c5600ba
23c7700
2b53471
617c30c
dcf6357
1175e6e
1683007
840a679
24a53df
df9875a
51bffb4
226e3ca
f4f6cfb
4b712d1
d76eeba
a76d544
5cad28e
2bf30b6
a0ccfe3
9cbbce8
9b181e4
cbfeb0e
d30b889
6828667
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 82 in cmd/jaeger/internal/extension/jaegerquery/server.go
Codecov / codecov/patch
cmd/jaeger/internal/extension/jaegerquery/server.go#L82
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it make sense to create
storage_v2/depstore/
before continuing, so that we don't have to keep this bifurcation?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yurishkuro Sure. What do we want to put in that package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about archive reader/writer, any reason not to upgrade them too? (or PR is too large?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yurishkuro I initially thought that we couldn't do this yet because I thought we were using the
ArchiveFactory
interface here. However, it seems like we just use the normal reader interface on the archive reader as well (see https://github.com/jaegertracing/jaeger/blob/main/cmd/query/app/querysvc/query_service.go#L69) so this can be done. I can do it in this PR or a separate one. Let me know if you have a preference.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of the other question (not having v2 reader fully implemented) it's ok to do these separately, no particular benefit afaict.