Add optional time window in TraceGetParameters #6159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
rim99
force-pushed
the
optinal-time-window-when-fetching-trace-by-id
branch
3 times, most recently
from
cb5f24f to
d00b4d3
Compare
rim99
changed the title
rim99
force-pushed
the
optinal-time-window-when-fetching-trace-by-id
branch
from
a0bb411 to
74fd1e5
Compare
yurishkuro
reviewed
Nov 17, 2024
yurishkuro
reviewed
Nov 17, 2024
yurishkuro
reviewed
Nov 17, 2024
This was referenced Nov 21, 2024
Closed
|
please rebase |
rim99
force-pushed
the
optinal-time-window-when-fetching-trace-by-id
branch
from
d6eeed8 to
2d6c9ed
Compare
Signed-off-by: rim99 <[email protected]>
rim99
force-pushed
the
optinal-time-window-when-fetching-trace-by-id
branch
from
7c3ab0c to
3d939f2
Compare
|
@yurishkuro Updated bsaed on comments, please reivew this PR, thanks |
yurishkuro
reviewed
Nov 21, 2024
Makefile.Protobuf.mk
Outdated
Comment on lines
17
to
20
| CONTAINER=docker | ||
| CONTAINER_PROTOBUF_VERSION=0.5.0 | ||
| CONTAINER_PROTOBUF=jaegertracing/protobuf:$(CONTAINER_PROTOBUF_VERSION) | ||
| PROTOC := ${CONTAINER} run --rm -u ${shell id -u} -v${PWD}:${PWD} -w${PWD} ${CONTAINER_PROTOBUF} --proto_path=${PWD} |
There was a problem hiding this comment.
Suggested change
| CONTAINER=docker | |
| CONTAINER_PROTOBUF_VERSION=0.5.0 | |
| CONTAINER_PROTOBUF=jaegertracing/protobuf:$(CONTAINER_PROTOBUF_VERSION) | |
| PROTOC := ${CONTAINER} run --rm -u ${shell id -u} -v${PWD}:${PWD} -w${PWD} ${CONTAINER_PROTOBUF} --proto_path=${PWD} | |
| DOCKER=docker | |
| DOCKER_PROTOBUF_VERSION=0.5.0 | |
| DOCKER_PROTOBUF=jaegertracing/protobuf:$(DOCKER_PROTOBUF_VERSION) | |
| PROTOC :=$(DOCKER) run --rm -u ${shell id -u} -v${PWD}:${PWD} -w${PWD} ${DOCKER_PROTOBUF} --proto_path=${PWD} |
yurishkuro
reviewed
Nov 21, 2024
| @@ -72,6 +72,14 @@ message GetTraceRequest { | |||
| (gogoproto.customtype) = "github.com/jaegertracing/jaeger/model.TraceID", | |||
| (gogoproto.customname) = "TraceID" | |||
| ]; | |||
| google.protobuf.Timestamp start_time = 2 [ | |||
| (gogoproto.stdtime) = true, | |||
| (gogoproto.nullable) = true | |||
There was a problem hiding this comment.
Suggested change
| (gogoproto.nullable) = true | |
| (gogoproto.nullable) = false |
yurishkuro
reviewed
Nov 21, 2024
| ]; | ||
| google.protobuf.Timestamp end_time = 3 [ | ||
| (gogoproto.stdtime) = true, | ||
| (gogoproto.nullable) = true |
There was a problem hiding this comment.
Suggested change
| (gogoproto.nullable) = true | |
| (gogoproto.nullable) = false |
yurishkuro
reviewed
Nov 21, 2024
| @@ -72,6 +72,14 @@ message GetTraceRequest { | |||
| (gogoproto.customtype) = "github.com/jaegertracing/jaeger/model.TraceID", | |||
| (gogoproto.customname) = "TraceID" | |||
| ]; | |||
| google.protobuf.Timestamp start_time = 2 [ | |||
There was a problem hiding this comment.
please move this change to a separate PR
|
@rim99 this PR is too large, please break it into logical pieces. At minimum grpc storage changes could be a separate PR, e.g. changing the IDL. The anonymizer change can be separate. |
|
you have jaeger-ui submodule change, it's not related |
4 tasks
Cool, I'll keep creating new PRs and rebasing until we're satisfied with the size of this PR. And first PR is: #6242 . Other changes rely on this |
4 tasks
Signed-off-by: Zhang Xin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Resolves #4150
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test